parthchandra commented on code in PR #13786:
URL: https://github.com/apache/iceberg/pull/13786#discussion_r2414483546
##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -1422,16 +1428,35 @@ public <D> CloseableIterable<D> build() {
}
if (batchedReaderFunc != null) {
- return new VectorizedParquetReader<>(
- file,
- schema,
- options,
- batchedReaderFunc,
- mapping,
- filter,
- reuseContainers,
- caseSensitive,
- maxRecordsPerBatch);
+ if (isComet) {
+ LOG.info("Comet vectorized reader enabled");
+ return new CometVectorizedParquetReader<>(
Review Comment:
@pvary thanks for verifying this. If any change is needed in future, it will
be fairly easy to move code around.
@huaxingao thank you for reviewing; there is also a follow up PR -
https://github.com/apache/iceberg/pull/14062 is in draft because it requires
this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
