huaxingao commented on code in PR #13786: URL: https://github.com/apache/iceberg/pull/13786#discussion_r2422466675
########## parquet/src/main/java/org/apache/iceberg/parquet/CometIOException.java: ########## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.parquet; + +import java.io.IOException; + +/** + * Exception class for handling both IOException and general Exception cases when working with Comet + * FileReader operations. This provides a unified way to handle exceptions that may occur during + * reflection-based calls to Comet classes. + */ +public class CometIOException extends RuntimeException { + + public CometIOException(String message) { + super(message); + } + + public CometIOException(String message, Throwable cause) { + super(message, cause); + } + + public CometIOException(Throwable cause) { + super(cause); + } + + /** Creates a CometIOException from an IOException. */ + public static CometIOException fromIOException(IOException cause) { + return new CometIOException("Comet IO operation failed", cause); + } + + /** Creates a CometIOException from a general Exception. */ + public static CometIOException fromException(Exception cause) { Review Comment: Seems a couple of the methods are not used. Shall we remove the no usages methods? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
