pvary commented on code in PR #14271:
URL: https://github.com/apache/iceberg/pull/14271#discussion_r2416118196
##########
data/src/main/java/org/apache/iceberg/data/BaseFileWriterFactory.java:
##########
@@ -37,9 +38,10 @@
import org.apache.iceberg.io.FileWriterFactory;
import org.apache.iceberg.orc.ORC;
import org.apache.iceberg.parquet.Parquet;
+import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap;
/** A base writer factory to be extended by query engine integrations. */
-public abstract class BaseFileWriterFactory<T> implements FileWriterFactory<T>
{
+public abstract class BaseFileWriterFactory<T> implements
FileWriterFactory<T>, Serializable {
Review Comment:
> Since FlinkFileWriterFactory is already marked as serializable. maybe we
don't need this change?
I had test failures. Flink was not able to serialize/deserialize the
factory, because the base class was not serializable.
> GenericFileWriterFactory ma be constructed with a regular and may not be
serializable.
BaseTable implements `writeReplace`, which makes sure that the table object
is always serializable
```
Object writeReplace() {
return SerializableTable.copyOf(this);
}
```
Added a test anyways.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
