pvary commented on code in PR #14271:
URL: https://github.com/apache/iceberg/pull/14271#discussion_r2412617023
##########
core/src/main/java/org/apache/iceberg/io/BaseTaskWriter.java:
##########
@@ -71,6 +72,23 @@ protected BaseTaskWriter(
this.spec = spec;
this.format = format;
this.appenderFactory = appenderFactory;
+ this.writerFactory = null;
+ this.fileFactory = fileFactory;
+ this.io = io;
+ this.targetFileSize = targetFileSize;
+ }
+
+ protected BaseTaskWriter(
Review Comment:
What we are missing is the `BaseEqualityDeltaWriter` - `RowDataDeltaWriter`
which keeps track of the previously written rows and create a position delete
if it is deleted again.
This could be done, but I would postpone it to another PR.
This PR would allow us to test the FileFormat API with Flink and also not
expose the WriteBuilder on the FormatModelRegistry
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
