stevenzwu commented on code in PR #14271:
URL: https://github.com/apache/iceberg/pull/14271#discussion_r2427033069
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/FlinkFileWriterFactory.java:
##########
@@ -42,13 +42,14 @@
import org.apache.iceberg.orc.ORC;
import org.apache.iceberg.parquet.Parquet;
import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
+import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap;
-class FlinkFileWriterFactory extends BaseFileWriterFactory<RowData> implements
Serializable {
+public class FlinkFileWriterFactory extends BaseFileWriterFactory<RowData>
implements Serializable {
Review Comment:
nit: looks like the `public` is only needed for `SimpleDataUtil` and other
test class. Should we add `@Internal` and `@VisibleForTest` annotations?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
