amogh-jahagirdar commented on code in PR #1758:
URL: https://github.com/apache/iceberg-rust/pull/1758#discussion_r2442569197
##########
crates/iceberg/src/delete_file_index.rs:
##########
@@ -169,10 +169,10 @@ impl PopulatedDeleteFileIndex {
self.global_deletes
.iter()
- // filter that returns true if the provided delete file's sequence
number is **greater than or equal to** `seq_num`
+ // filter that returns true if the provided delete file's sequence
number is **greater than** `seq_num`
Review Comment:
I could just be missing something in the implementation, but right now seems
like we're over applying in a way that would technically be incorrect. If a
snapshot has some added data files and an equality delete, the equality deletes
should only be applied to older seq numbers. We do this correctly for partition
scoped eq deletes below, but for some reason the global equality delete
matching is different; the seq number criteria for eq deletes applies
regardless of scope of the delete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
