kevinjqliu commented on code in PR #1758:
URL: https://github.com/apache/iceberg-rust/pull/1758#discussion_r2442704646
##########
crates/iceberg/src/delete_file_index.rs:
##########
@@ -169,10 +169,10 @@ impl PopulatedDeleteFileIndex {
self.global_deletes
.iter()
- // filter that returns true if the provided delete file's sequence
number is **greater than or equal to** `seq_num`
+ // filter that returns true if the provided delete file's sequence
number is **greater than** `seq_num`
Review Comment:
Thanks for catching this. I think "greater than" is correct here. The
`global_deletes` variable is used for gathering all the eq delete files for an
unpartitioned table, but the same logic should still apply.
Looking at past commits, i did find this was previously discussed
[here](https://github.com/apache/iceberg-rust/pull/1077#discussion_r2000091436)
Also from https://iceberg.apache.org/spec/#scan-planning
<img width="767" height="429" alt="Screenshot 2025-10-18 at 5 57 03 PM"
src="https://github.com/user-attachments/assets/dd339e0c-6207-4bfb-8f87-6192178e5697";
/>
This implies that we should not apply eq delete files that have equivalent
sequence number
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
