Copilot commented on code in PR #1758:
URL: https://github.com/apache/iceberg-rust/pull/1758#discussion_r2445510632
##########
crates/iceberg/src/delete_file_index.rs:
##########
@@ -167,12 +168,12 @@ impl PopulatedDeleteFileIndex {
) -> Vec<FileScanTaskDeleteFile> {
let mut results = vec![];
- self.global_deletes
+ self.global_equality_deletes
.iter()
- // filter that returns true if the provided delete file's sequence
number is **greater than or equal to** `seq_num`
+ // filter that returns true if the provided delete file's sequence
number is **greater than** `seq_num`
Review Comment:
The comment is inaccurate. The filter returns true if the delete file's
sequence number is **strictly greater than** `seq_num`, not if it's greater
than or equal to. Consider revising to: '// filter that returns true if the
provided delete file's sequence number is strictly greater than `seq_num`'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
