zhjwpku commented on code in PR #267:
URL: https://github.com/apache/iceberg-cpp/pull/267#discussion_r2446547313
##########
src/iceberg/util/temporal_util.h:
##########
@@ -19,12 +19,27 @@
#pragma once
+#include <cstdint>
+
#include "iceberg/iceberg_export.h"
#include "iceberg/result.h"
#include "iceberg/type_fwd.h"
namespace iceberg {
+struct ICEBERG_EXPORT TemporalParts {
+ int32_t year{0};
+ uint16_t month{0};
+ uint16_t day{0};
Review Comment:
I avoided using std::chrono::month and std::chrono::day to not including
<chrono>, but I might be overthinking it. Will try, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
