zhjwpku commented on code in PR #267: URL: https://github.com/apache/iceberg-cpp/pull/267#discussion_r2448754536
########## src/iceberg/util/temporal_util.cc: ########## @@ -20,6 +20,7 @@ #include "iceberg/util/temporal_util.h" #include <chrono> +#include <cstdint> Review Comment: This hasn't been directly added by the temporal_util.h, there are uses of `int32_t` in this file, so I think include the header is fine? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
