wgtmac commented on code in PR #267:
URL: https://github.com/apache/iceberg-cpp/pull/267#discussion_r2446576799
##########
src/iceberg/util/temporal_util.h:
##########
@@ -19,12 +19,27 @@
#pragma once
+#include <cstdint>
+
#include "iceberg/iceberg_export.h"
#include "iceberg/result.h"
#include "iceberg/type_fwd.h"
namespace iceberg {
+struct ICEBERG_EXPORT TemporalParts {
Review Comment:
Perhaps we should not reuse a single structure to create different temporal
types, which leads to unused fields.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
