singhpk234 commented on code in PR #14380:
URL: https://github.com/apache/iceberg/pull/14380#discussion_r2449280988
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -1521,6 +1521,11 @@ public Builder setPreviousFileLocation(String
previousFileLocation) {
return this;
}
+ public Builder setLastUpdatedMillis(long lastUpdatedMillis) {
+ this.lastUpdatedMillis = lastUpdatedMillis;
+ return this;
+ }
Review Comment:
Is this just for DDL or DML like add snapshot too ?
if its for adding snapshots too,
then do we need to make sure this is called before addSnapshot() / setRef
and handle the setRef that don't take timestamp fom the snapshot obj ?
https://github.com/apache/iceberg/blob/f65558ec30a27fb26ed85ba0e3dc4e498f2c046b/core/src/main/java/org/apache/iceberg/TableMetadata.java#L1317
if we call this after addSnapshot() / setRef then my snapshot logs would
reference different time than the metadata log ?
https://github.com/apache/iceberg/blob/f65558ec30a27fb26ed85ba0e3dc4e498f2c046b/core/src/main/java/org/apache/iceberg/TableMetadata.java#L1326
if its just for DDL do we need to assert its just for ops which doesn't add
snapshot ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
