dramaticlly commented on code in PR #14380:
URL: https://github.com/apache/iceberg/pull/14380#discussion_r2450041254


##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -1521,6 +1521,11 @@ public Builder setPreviousFileLocation(String 
previousFileLocation) {
       return this;
     }
 
+    public Builder setLastUpdatedMillis(long lastUpdatedMillis) {
+      this.lastUpdatedMillis = lastUpdatedMillis;
+      return this;
+    }

Review Comment:
   That's a good callout, currently the SnapshotLogEntry and MetadataLogEntry 
share the same lastUpdatedMillis and want to minimize the change here. Updated 
to only set if existing value is null



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to