stevenzwu commented on code in PR #14380:
URL: https://github.com/apache/iceberg/pull/14380#discussion_r2449333429
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -1521,6 +1521,11 @@ public Builder setPreviousFileLocation(String
previousFileLocation) {
return this;
}
+ public Builder setLastUpdatedMillis(long lastUpdatedMillis) {
+ this.lastUpdatedMillis = lastUpdatedMillis;
+ return this;
+ }
Review Comment:
agree that this new setter shouldn't be called after `addSnapshot` (or any
other existing code paths setting the timestamp). maybe we can assert that this
setter is allowed only if the existing timestamp value is `null`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
