singhpk234 commented on code in PR #14479:
URL: https://github.com/apache/iceberg/pull/14479#discussion_r2484245997
##########
aws/src/integration/java/org/apache/iceberg/aws/s3/signer/TestS3RestSigner.java:
##########
@@ -394,15 +393,15 @@ protected String calculateContentHash(
SdkChecksum contentFlexibleChecksum) {
boolean isUnsignedStreamingTrailer =
mutableRequest
- .firstMatchingHeader(SignerConstant.X_AMZ_CONTENT_SHA256)
+ .firstMatchingHeader("x-amz-content-sha256")
Review Comment:
do we know why this header constant was dropped ?
I was try to dig in :
https://docs.aws.amazon.com/AmazonS3/latest/API/sig-v4-header-based-auth.html
```
In both cases, because the x-amz-content-sha256 header value is already part
of your HashedPayload, you are not required to include the x-amz-content-sha256
header as a canonical header.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
