singhpk234 commented on code in PR #14519:
URL: https://github.com/apache/iceberg/pull/14519#discussion_r2499923312


##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -1192,6 +1192,13 @@ paths:
         - Catalog API
       summary: Load vended credentials for a table from the catalog
       operationId: loadCredentials
+      parameters:
+        - name: planId
+          in: query
+          required: false
+          schema:
+            type: string
+          description: The plan ID that has been used for server-side scan 
planning

Review Comment:
   [implementation related] how are we planning to keep track of the plan-id, 
when there are concurrent scans in progress. I was thinking this in parallel 
too. 
   
   do you plan to re-use the same FileIO obj which an object store provider 
client / cred provider per plan-id or a wrapping file-IO with new API
   
   ```
   io(plan-id)
   ```
   that returns the file-IO per the plan-id ? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to