nastra commented on code in PR #14519:
URL: https://github.com/apache/iceberg/pull/14519#discussion_r2537774290
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -1192,6 +1192,13 @@ paths:
- Catalog API
summary: Load vended credentials for a table from the catalog
operationId: loadCredentials
+ parameters:
+ - name: planId
+ in: query
+ required: false
+ schema:
+ type: string
+ description: The plan ID that has been used for server-side scan
planning
Review Comment:
> Is there a use case that returning the generic credentials when plan id is
invalid?
Yes, this is a valid use case where a server could decide to throw an error
when the planId is invalid, or it could decide to just return generic
credentials. Given that both cases up to the server implementation do we want
to add wording to the spec that might indicate one or the other? Leaving this
out from the spec leaves room for the server impl to decide this and that is
the intention here.
Does that make sense @flyrain or do you think we should have additional
wording in the spec?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
