danielcweeks commented on code in PR #14519:
URL: https://github.com/apache/iceberg/pull/14519#discussion_r2516210926


##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -1192,6 +1192,13 @@ paths:
         - Catalog API
       summary: Load vended credentials for a table from the catalog
       operationId: loadCredentials
+      parameters:
+        - name: planId
+          in: query
+          required: false
+          schema:
+            type: string
+          description: The plan ID that has been used for server-side scan 
planning

Review Comment:
   I think we're going to have to figure out the implementation side of this 
separate from what we need in the spec.  We definitely need to isolate the scan 
requests and associated storage credentials from the load table, which is 
largely what this spec change entails.  I think there are a few options to pass 
the credentials or setting a new FileIO for the table instance used by the plan 
result, but that's more how do we wire this up.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to