pvary commented on code in PR #14414:
URL: https://github.com/apache/iceberg/pull/14414#discussion_r2517399476


##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicWriter.java:
##########
@@ -118,10 +117,6 @@ public void write(DynamicRecordInternal element, Context 
context)
                               !equalityFieldIds.isEmpty(),
                               "Equality field columns shouldn't be empty when 
configuring to use UPSERT data.");
 
-                          Preconditions.checkArgument(
-                              !(TableUtil.formatVersion(table) > 2),

Review Comment:
   Quick question: Do we support V1 tables in Dynamic Sink?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to