Guosmilesmile commented on PR #14414: URL: https://github.com/apache/iceberg/pull/14414#issuecomment-3519799031
Pointing out something I found in this PR. It doesn't have an impact now, but I feel this part will need adjustment sooner or later. The writeDataFiles method hardcodes FORMAT_V2; perhaps it should correspond to the actual table version? Is there any historical reason for this? https://github.com/apache/iceberg/blob/0ce14b7ffd77337a4aee3de5cd19e697e731c19e/flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/FlinkManifestUtil.java#L49-L59 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
