Fokko commented on code in PR #14565:
URL: https://github.com/apache/iceberg/pull/14565#discussion_r2523284751
##########
open-api/rest-catalog-open-api.py:
##########
@@ -1439,6 +1439,11 @@ class PlanTableScanRequest(BaseModel):
filter: Optional[Expression] = Field(
None, description='Expression used to filter the table data'
)
+ min_rows_requested: Optional[int] = Field(
Review Comment:
I find the name and description a bit confusing. For me, it is obvious that
it might not return exactly the number of rows that are requested. For example,
the table might be empty. I would much rather go with something that's analogue
to SQL:
```suggestion
limit: Optional[int] = Field(
```
Of course, it might still return more rows since the Parquet file contains
more rows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
