emkornfield commented on code in PR #14565:
URL: https://github.com/apache/iceberg/pull/14565#discussion_r2524423047
##########
open-api/rest-catalog-open-api.py:
##########
@@ -1439,6 +1439,11 @@ class PlanTableScanRequest(BaseModel):
filter: Optional[Expression] = Field(
None, description='Expression used to filter the table data'
)
+ min_rows_requested: Optional[int] = Field(
Review Comment:
just to jump in on bike shedding how about `max_rows_required` I think it
lacks the ambiguity if someone isn't familiar with SQL and I think my issue
with and hopefully makes it clearer that this is in fact an upper bound?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
