emkornfield commented on code in PR #14565:
URL: https://github.com/apache/iceberg/pull/14565#discussion_r2525116863


##########
open-api/rest-catalog-open-api.py:
##########
@@ -1439,6 +1439,11 @@ class PlanTableScanRequest(BaseModel):
     filter: Optional[Expression] = Field(
         None, description='Expression used to filter the table data'
     )
+    min_rows_requested: Optional[int] = Field(

Review Comment:
   > just to pile on. target-scan-task-number
   
   I might be misunderstanding but I think this is finer grained then number of 
tasks.  We are looking for a row count, so i you say 1000, this could be 1000 
tasks with one row each or 1 task with 1000+ rows



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to