jordepic commented on code in PR #14578:
URL: https://github.com/apache/iceberg/pull/14578#discussion_r2528029986
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/TableCreator.java:
##########
@@ -16,26 +16,27 @@
* specific language governing permissions and limitations
* under the License.
*/
-package org.apache.iceberg.stats;
+package org.apache.iceberg.flink.sink.dynamic;
-import java.util.List;
-import org.apache.iceberg.StructLike;
-import org.apache.iceberg.types.Types;
+import org.apache.iceberg.PartitionSpec;
+import org.apache.iceberg.Schema;
+import org.apache.iceberg.Table;
+import org.apache.iceberg.catalog.Catalog;
+import org.apache.iceberg.catalog.TableIdentifier;
-public interface ContentStats extends StructLike {
+@FunctionalInterface
+public interface TableCreator {
- /** A list of all the {@link FieldStats} */
- List<FieldStats<?>> fieldStats();
+ TableCreator DEFAULT = new DefaultTableCreator();
Review Comment:
Done.
##########
docs/docs/flink-writes.md:
##########
@@ -487,6 +487,7 @@ We need the following information (DynamicRecord) for every
record:
| `Parallelism` | The maximum number of parallel writers for a given
table/branch/schema/spec (WriteTarget). |
| `UpsertMode` | Overrides this table's write.upsert.enabled (optional).
|
| `EqualityFields` | The equality fields for the table(optional).
|
+| `tableCreator(TableCreator creator)` | When DynamicIcebergSink creates new
Iceberg tables, allows overriding how tables are created - setting custom table
properties and location based on the table name. |
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
