mxm commented on code in PR #14578:
URL: https://github.com/apache/iceberg/pull/14578#discussion_r2528165077
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/TableCreator.java:
##########
@@ -16,26 +16,18 @@
* specific language governing permissions and limitations
* under the License.
*/
-package org.apache.iceberg.stats;
+package org.apache.iceberg.flink.sink.dynamic;
-import java.util.List;
-import org.apache.iceberg.StructLike;
-import org.apache.iceberg.types.Types;
+import org.apache.iceberg.PartitionSpec;
+import org.apache.iceberg.Schema;
+import org.apache.iceberg.Table;
+import org.apache.iceberg.catalog.Catalog;
+import org.apache.iceberg.catalog.TableIdentifier;
-public interface ContentStats extends StructLike {
+@FunctionalInterface
+public interface TableCreator {
- /** A list of all the {@link FieldStats} */
- List<FieldStats<?>> fieldStats();
+ TableCreator DEFAULT = Catalog::createTable;
- /**
- * Returns a {@link FieldStats} instance holding field stats for the given
field ID.
- *
- * @param fieldId The field ID to retrieve {@link FieldStats} for
- * @return A {@link FieldStats} instance holding field stats for the given
field ID.
- * @param <T> The type of the underlying {@link FieldStats} instance.
- */
- <T> FieldStats<T> statsFor(int fieldId);
-
- /** The stats struct holding nested structs with their respective field
stats */
- Types.StructType statsStruct();
+ Table createTable(Catalog catalog, TableIdentifier identifier, Schema
schema, PartitionSpec spec);
Review Comment:
Never mind, I missed the Catalog parameter. Users will be able to call the
above method and provide a location.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
