jordepic commented on code in PR #14578:
URL: https://github.com/apache/iceberg/pull/14578#discussion_r2528164094
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/TableCreator.java:
##########
@@ -16,26 +16,18 @@
* specific language governing permissions and limitations
* under the License.
*/
-package org.apache.iceberg.stats;
+package org.apache.iceberg.flink.sink.dynamic;
-import java.util.List;
-import org.apache.iceberg.StructLike;
-import org.apache.iceberg.types.Types;
+import org.apache.iceberg.PartitionSpec;
+import org.apache.iceberg.Schema;
+import org.apache.iceberg.Table;
+import org.apache.iceberg.catalog.Catalog;
+import org.apache.iceberg.catalog.TableIdentifier;
-public interface ContentStats extends StructLike {
+@FunctionalInterface
+public interface TableCreator {
- /** A list of all the {@link FieldStats} */
- List<FieldStats<?>> fieldStats();
+ TableCreator DEFAULT = Catalog::createTable;
- /**
- * Returns a {@link FieldStats} instance holding field stats for the given
field ID.
- *
- * @param fieldId The field ID to retrieve {@link FieldStats} for
- * @return A {@link FieldStats} instance holding field stats for the given
field ID.
- * @param <T> The type of the underlying {@link FieldStats} instance.
- */
- <T> FieldStats<T> statsFor(int fieldId);
-
- /** The stats struct holding nested structs with their respective field
stats */
- Types.StructType statsStruct();
+ Table createTable(Catalog catalog, TableIdentifier identifier, Schema
schema, PartitionSpec spec);
Review Comment:
Discussed offline. We're passing in location = null here.
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/TableCreator.java:
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iceberg.flink.sink.dynamic;
+
+import org.apache.iceberg.PartitionSpec;
+import org.apache.iceberg.Schema;
+import org.apache.iceberg.Table;
+import org.apache.iceberg.catalog.Catalog;
+import org.apache.iceberg.catalog.TableIdentifier;
+
+@FunctionalInterface
+public interface TableCreator {
+
+ TableCreator DEFAULT = new DefaultTableCreator();
+
+ Table createTable(Catalog catalog, TableIdentifier identifier, Schema
schema, PartitionSpec spec);
Review Comment:
Discussed offline, leaving for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
