yyanyy commented on a change in pull request #1641:
URL: https://github.com/apache/iceberg/pull/1641#discussion_r517590590



##########
File path: 
parquet/src/main/java/org/apache/iceberg/parquet/ParquetValueWriters.java
##########
@@ -113,8 +115,8 @@ private ParquetValueWriters() {
     return new MapWriter<>(dl, rl, keyWriter, valueWriter);
   }
 
+  @SuppressWarnings("checkstyle:VisibilityModifier")

Review comment:
       This was due to `column` being directly accessed by its child classes; 
originally I added `id` in the same way so I moved this suppression out, but 
now since we don't need to make change to this class, I'll move it back. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to