singhpk234 commented on code in PR #14615:
URL: https://github.com/apache/iceberg/pull/14615#discussion_r2538418201
##########
api/src/main/java/org/apache/iceberg/Scan.java:
##########
@@ -195,4 +195,18 @@ default ThisT metricsReporter(MetricsReporter reporter) {
throw new UnsupportedOperationException(
this.getClass().getName() + " doesn't implement metricsReporter");
}
+
+ /**
+ * Create a new scan that returns files with at least the given number of
rows. This is used as a
+ * hint during server-side scan planning to not have to return more rows
than necessary. It is not
Review Comment:
why only server-side scan planning, we can extend this to any scan ?
if the intention is strictly to make it for server-side scan i would
recommend another interface which implementation can implement both Scan and
LimitAwareScan (?)
##########
core/src/main/java/org/apache/iceberg/BaseScan.java:
##########
@@ -293,6 +293,11 @@ public ThisT metricsReporter(MetricsReporter reporter) {
return newRefinedScan(table, schema, context.reportWith(reporter));
}
+ @Override
+ public ThisT minRowsRequested(int numRows) {
+ return newRefinedScan(table, schema, context.minRowsRequested(numRows));
+ }
Review Comment:
```suggestion
public ThisT minRowsRequested(Integer numRows) {
return newRefinedScan(table, schema, context.minRowsRequested(numRows));
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
