singhpk234 commented on code in PR #14615:
URL: https://github.com/apache/iceberg/pull/14615#discussion_r2551918166
##########
api/src/main/java/org/apache/iceberg/Scan.java:
##########
@@ -195,4 +195,15 @@ default ThisT metricsReporter(MetricsReporter reporter) {
throw new UnsupportedOperationException(
this.getClass().getName() + " doesn't implement metricsReporter");
}
+
+ /**
+ * Create a new scan that returns files with at least the given number of
rows.
+ *
+ * @param numRows The minimum number of rows requested
Review Comment:
IMHO we would need to define this like we did in spec ? like its a hint and
scan is strictly not required to return that many rows ?
##########
core/src/main/java/org/apache/iceberg/BaseScan.java:
##########
@@ -293,6 +293,11 @@ public ThisT metricsReporter(MetricsReporter reporter) {
return newRefinedScan(table, schema, context.reportWith(reporter));
}
+ @Override
+ public ThisT minRowsRequested(long numRows) {
+ return newRefinedScan(table, schema, context.minRowsRequested(numRows));
+ }
Review Comment:
How are we gating that this is only being called for RESTCatalog as for
other things its a No-op ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
