nastra commented on code in PR #14615:
URL: https://github.com/apache/iceberg/pull/14615#discussion_r2563930542
##########
core/src/main/java/org/apache/iceberg/BaseScan.java:
##########
@@ -293,6 +293,11 @@ public ThisT metricsReporter(MetricsReporter reporter) {
return newRefinedScan(table, schema, context.reportWith(reporter));
}
+ @Override
+ public ThisT minRowsRequested(long numRows) {
+ return newRefinedScan(table, schema, context.minRowsRequested(numRows));
+ }
Review Comment:
it would trigger a `BaseMetadataTableScan` which also extends `BaseScan`, so
this code should cover scans against normal and metadata tables. Let me add a
test for this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
