rdblue commented on a change in pull request #1618:
URL: https://github.com/apache/iceberg/pull/1618#discussion_r518324923
##########
File path: flink/src/main/java/org/apache/iceberg/flink/CatalogLoader.java
##########
@@ -45,12 +45,22 @@
*/
Catalog loadCatalog();
- static CatalogLoader hadoop(String name, Configuration hadoopConf, String
warehouseLocation) {
- return new HadoopCatalogLoader(name, hadoopConf, warehouseLocation);
+ static CatalogLoader hadoop(
+ String name,
+ Configuration hadoopConf,
+ String warehouseLocation,
+ Map<String, String> properties) {
+ return new HadoopCatalogLoader(name, hadoopConf, warehouseLocation,
properties);
Review comment:
> also give a fixed serialization id for those classes because Flink
serializes the catalog loader
We know that serialization across Iceberg versions may be a problem, but I'm
not sure that we want to introduce a serialization id. In general, we avoid
this because we _want_ serialization to fail if there are multiple library
versions. Java serialization isn't something that we want to use for
compatibility across versions. The cases where we have multiple library
versions are rare, and we want to design something for a rolling update.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
