jackye1995 commented on a change in pull request #1618:
URL: https://github.com/apache/iceberg/pull/1618#discussion_r518575944
##########
File path: hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java
##########
@@ -69,13 +73,24 @@ public HiveCatalog(Configuration conf) {
this.conf = conf;
this.createStack = Thread.currentThread().getStackTrace();
this.closed = false;
+ this.fileIO = new HadoopFileIO(conf);
}
public HiveCatalog(String name, String uri, int clientPoolSize,
Configuration conf) {
this(name, uri, null, clientPoolSize, conf);
}
public HiveCatalog(String name, String uri, String warehouse, int
clientPoolSize, Configuration conf) {
+ this(name, uri, warehouse, clientPoolSize, conf, Maps.newHashMap());
+ }
+
+ public HiveCatalog(
+ String name,
+ String uri,
+ String warehouse,
+ int clientPoolSize,
+ Configuration conf,
+ Map<String, String> properties) {
Review comment:
I see, sorry I did not see the comments and get a chance to change it
before the merge. I guess this kind of issue will be less frequent as I get
more familiar with the code style here, but feel free to ping me at any time
and I can fix all the style issues before merge 😃
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
