gaborkaszab commented on code in PR #14440:
URL: https://github.com/apache/iceberg/pull/14440#discussion_r2577190775
##########
core/src/main/java/org/apache/iceberg/util/PropertyUtil.java:
##########
@@ -127,6 +129,21 @@ public static String propertyAsString(
return defaultValue;
}
+ public static <E extends Enum<E>> E propertyAsEnum(
Review Comment:
I think we only have a handful of places where we use enums as configs. I
think the example I showed above is pretty simple itself, I'd not complicate
this PR with adding new functionality to PropertyUtil (including tests). If we
still want to have such functionality, in a separate PR would make sense, and
then all the other occasions could be replaced together. If we merge this we'll
have this approach and the other approach I showed besides each other, would be
better to keep it uniform.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
