gaborkaszab commented on code in PR #14440:
URL: https://github.com/apache/iceberg/pull/14440#discussion_r2577243619
##########
core/src/test/java/org/apache/iceberg/hadoop/TestCachingCatalog.java:
##########
@@ -407,6 +407,37 @@ public void testInvalidateTableForChainedCachingCatalogs()
throws Exception {
assertThat(wrappedCatalog.cache().asMap()).doesNotContainKey(tableIdent);
}
+ @Test
+ public void testCachePolicyExpireAfterWrite() throws Exception {
+ TestableCachingCatalog catalog =
+ TestableCachingCatalog.wrap(
+ hadoopCatalog(),
+ EXPIRATION_TTL,
+ ticker,
+ CatalogProperties.CacheExpirationPolicy.EXPIRE_AFTER_WRITE);
+
+ Namespace namespace = Namespace.of("db", "ns1", "ns2");
+ TableIdentifier tableIdent = TableIdentifier.of(namespace, "tbl");
+ catalog.createTable(tableIdent, SCHEMA, SPEC, ImmutableMap.of("key",
"value"));
+
+ // Ensure table is cached with full ttl remaining upon creation
+ assertThat(catalog.cache().asMap()).containsKey(tableIdent);
+
assertThat(catalog.remainingAgeFor(tableIdent)).isPresent().get().isEqualTo(EXPIRATION_TTL);
+
+ ticker.advance(HALF_OF_EXPIRATION);
+ assertThat(catalog.cache().asMap()).containsKey(tableIdent);
+
assertThat(catalog.ageOf(tableIdent)).isPresent().get().isEqualTo(HALF_OF_EXPIRATION);
+
+ // Access the cache to check policy behaviour
+ catalog.loadTable(tableIdent);
Review Comment:
an extra check might make sense between loadTable and ticker.advance to see
if the age is unchanged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
