CTTY commented on code in PR #1889:
URL: https://github.com/apache/iceberg-rust/pull/1889#discussion_r2578299788
##########
crates/iceberg/src/writer/base_writer/data_file_writer.rs:
##########
@@ -47,13 +47,13 @@ where
#[async_trait::async_trait]
impl<B, L, F> IcebergWriterBuilder for DataFileWriterBuilder<B, L, F>
where
- B: FileWriterBuilder,
- L: LocationGenerator,
- F: FileNameGenerator,
+ B: FileWriterBuilder + Sync,
+ L: LocationGenerator + Sync,
+ F: FileNameGenerator + Sync,
Review Comment:
I think we should just add supertrait `Sync` to these traits to enforce it
across different implementations
##########
crates/iceberg/src/writer/base_writer/equality_delete_writer.rs:
##########
@@ -117,17 +117,17 @@ impl EqualityDeleteWriterConfig {
#[async_trait::async_trait]
impl<B, L, F> IcebergWriterBuilder for EqualityDeleteFileWriterBuilder<B, L, F>
where
- B: FileWriterBuilder,
- L: LocationGenerator,
- F: FileNameGenerator,
+ B: FileWriterBuilder + Sync,
+ L: LocationGenerator + Sync,
+ F: FileNameGenerator + Sync,
Review Comment:
Same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
