leonzchang commented on code in PR #1889:
URL: https://github.com/apache/iceberg-rust/pull/1889#discussion_r2585172819
##########
crates/iceberg/src/writer/file_writer/mod.rs:
##########
@@ -36,11 +36,11 @@ pub mod rolling_writer;
type DefaultOutput = Vec<DataFileBuilder>;
/// File writer builder trait.
-pub trait FileWriterBuilder<O = DefaultOutput>: Send + Clone + 'static {
+pub trait FileWriterBuilder<O = DefaultOutput>: Clone + Send + Sync + 'static {
Review Comment:
In the `RollingFileWriterBuilder::build` function, even though we change the
builder not self-consumed, its inner still need to be cloned at the lowest
levels of the construction chain.
`IcebergWriterBuilder` → `RollingFileWriterBuilder` → `FileWriterBuilder` /
`LocationGenerator` / `FileNameGenerator`.
For reference
https://github.com/apache/iceberg-rust/pull/1735#discussion_r2437282079.
https://github.com/apache/iceberg-rust/blob/b58c4636679dadd508db2dc3c62accea1cafe877/crates/iceberg/src/writer/file_writer/rolling_writer.rs#L106-L116
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
