liurenjie1024 commented on code in PR #1889:
URL: https://github.com/apache/iceberg-rust/pull/1889#discussion_r2584609560
##########
crates/iceberg/src/writer/file_writer/location_generator.rs:
##########
@@ -24,7 +24,7 @@ use crate::Result;
use crate::spec::{DataFileFormat, PartitionKey, TableMetadata};
/// `LocationGenerator` used to generate the location of data file.
-pub trait LocationGenerator: Clone + Send + 'static {
+pub trait LocationGenerator: Clone + Send + Sync + 'static {
Review Comment:
Ditto.
##########
crates/iceberg/src/writer/file_writer/location_generator.rs:
##########
@@ -94,7 +94,7 @@ impl LocationGenerator for DefaultLocationGenerator {
}
/// `FileNameGeneratorTrait` used to generate file name for data file. The
file name can be passed to `LocationGenerator` to generate the location of the
file.
-pub trait FileNameGenerator: Clone + Send + 'static {
+pub trait FileNameGenerator: Clone + Send + Sync + 'static {
Review Comment:
Ditto.
##########
crates/iceberg/src/writer/file_writer/mod.rs:
##########
@@ -36,11 +36,11 @@ pub mod rolling_writer;
type DefaultOutput = Vec<DataFileBuilder>;
/// File writer builder trait.
-pub trait FileWriterBuilder<O = DefaultOutput>: Send + Clone + 'static {
+pub trait FileWriterBuilder<O = DefaultOutput>: Clone + Send + Sync + 'static {
Review Comment:
Why we need to keep this `Clone`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
