rambleraptor commented on code in PR #14447:
URL: https://github.com/apache/iceberg/pull/14447#discussion_r2604554181
##########
bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/BigQueryMetastoreCatalog.java:
##########
@@ -128,16 +150,40 @@ void initialize(
LocationUtil.stripTrailingSlash(properties.get(CatalogProperties.WAREHOUSE_LOCATION));
}
+ Map<String, String> fileIOProperties = prepareFileIOProperties(properties,
initialProjectId);
+
this.fileIO =
CatalogUtil.loadFileIO(
properties.getOrDefault(
CatalogProperties.FILE_IO_IMPL,
"org.apache.iceberg.io.ResolvingFileIO"),
- properties,
+ fileIOProperties,
conf);
this.listAllTables =
Boolean.parseBoolean(properties.getOrDefault(LIST_ALL_TABLES, "true"));
}
+ @VisibleForTesting
+ Map<String, String> prepareFileIOProperties(Map<String, String> properties,
String gcpProjectId) {
Review Comment:
In my mind, all of the various file providers should try to act as similarly
as possible. If S3 is doing things one way, we should try to do the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
