danielcweeks commented on code in PR #14447: URL: https://github.com/apache/iceberg/pull/14447#discussion_r2604662703
########## bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/BigQueryClientFactory.java: ########## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.gcp.bigquery; + +import com.google.cloud.bigquery.BigQueryOptions; +import java.io.Serializable; +import java.util.Map; + +/** + * Factory for creating configured BigQueryOptions (pluggable auth). Implementations create + * BigQueryOptions from catalog properties. + */ +public interface BigQueryClientFactory extends Serializable { Review Comment: The S3 implementation here is a little messy because you have to configure different `client.factory` to get the assume role functionality. So you would actually have to set the factory implementation and the properties to get the different behavior for a catalog instance and the S3FileIO instance. So, what is split across multiple factory implementations and multiple properties implementations can be better handled in this case. I wouldn't advise following that pattern. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
