joyhaldar commented on code in PR #14447:
URL: https://github.com/apache/iceberg/pull/14447#discussion_r2631139790
##########
gcp/src/main/java/org/apache/iceberg/gcp/GCPProperties.java:
##########
@@ -49,6 +49,12 @@ public class GCPProperties implements Serializable {
public static final String GCS_OAUTH2_REFRESH_CREDENTIALS_ENDPOINT =
"gcs.oauth2.refresh-credentials-endpoint";
+ // Impersonation properties
+ public static final String GCS_IMPERSONATE_SERVICE_ACCOUNT =
"gcp.impersonate.service-account";
+ public static final String GCS_IMPERSONATE_LIFETIME_SECONDS =
"gcp.impersonate.lifetime-seconds";
+ public static final String GCS_IMPERSONATE_DELEGATES =
"gcp.impersonate.delegates";
+ public static final int GCS_IMPERSONATE_LIFETIME_SECONDS_DEFAULT = 3600;
+
Review Comment:
Hello Daniel, I've added configurable scopes for GCS impersonation.
Addressed the property naming question in [my reply to the other
comment](https://github.com/apache/iceberg/pull/14447#discussion_r2631135321).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
