aokolnychyi commented on a change in pull request #1738:
URL: https://github.com/apache/iceberg/pull/1738#discussion_r521505089
##########
File path: core/src/main/java/org/apache/iceberg/TableProperties.java
##########
@@ -134,4 +134,10 @@ private TableProperties() {
public static final String ENGINE_HIVE_ENABLED = "engine.hive.enabled";
public static final boolean ENGINE_HIVE_ENABLED_DEFAULT = false;
+
+ public static final String WRITE_ISOLATION_LEVEL = "write.isolation-level";
Review comment:
My current thinking on naming here is that all query engines use the
same API to commit. Right now, we only have appends that guarantee serializable
isolation. I think query engines supporting update/delete/merge should respect
this property or throw an exception if they cannot satisfy the required
isolation level.
We may add a property specific to query engines if we think we will need
different defaults. I'd say those will be optional. If a query engine specific
value is not set, use this for all engines.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
