aokolnychyi commented on a change in pull request #1738:
URL: https://github.com/apache/iceberg/pull/1738#discussion_r521641516
##########
File path: core/src/main/java/org/apache/iceberg/TableProperties.java
##########
@@ -134,4 +134,10 @@ private TableProperties() {
public static final String ENGINE_HIVE_ENABLED = "engine.hive.enabled";
public static final boolean ENGINE_HIVE_ENABLED_DEFAULT = false;
+
+ public static final String WRITE_ISOLATION_LEVEL = "write.isolation-level";
Review comment:
Dynamic partition overwrite does mess up the situation. I like the
`row-level` namespace we introduced for properties. We could make it
`write.row-level.isolation` to match `write.row-level.mode`. That way, it is
clear it applies only to update/delete/merge.
If we decide to have engine specific defaults later, we can introduce
`write.row-level.spark.isolation` or `engine.spark.write.row-level.isolation`.
The latter can serve as a basis for providing any engine specific properties..
##########
File path: core/src/main/java/org/apache/iceberg/TableProperties.java
##########
@@ -134,4 +134,10 @@ private TableProperties() {
public static final String ENGINE_HIVE_ENABLED = "engine.hive.enabled";
public static final boolean ENGINE_HIVE_ENABLED_DEFAULT = false;
+
+ public static final String WRITE_ISOLATION_LEVEL = "write.isolation-level";
Review comment:
Dynamic partition overwrite does mess up the situation. I like the
`row-level` namespace we introduced for properties. We could make it
`write.row-level.isolation` to match `write.row-level.mode`. That way, it is
clear it applies only to update/delete/merge.
If we decide to have engine specific defaults later, we can introduce
`write.row-level.spark.isolation` or `engine.spark.write.row-level.isolation`.
The latter can serve as a basis for providing any engine specific properties.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
