rdblue commented on a change in pull request #1738:
URL: https://github.com/apache/iceberg/pull/1738#discussion_r521573168
##########
File path: core/src/main/java/org/apache/iceberg/TableProperties.java
##########
@@ -134,4 +134,10 @@ private TableProperties() {
public static final String ENGINE_HIVE_ENABLED = "engine.hive.enabled";
public static final boolean ENGINE_HIVE_ENABLED_DEFAULT = false;
+
+ public static final String WRITE_ISOLATION_LEVEL = "write.isolation-level";
Review comment:
My only reservation about this is that the isolation level varies by
operation. Dynamic partition replacement doesn't check whether the partitions
that will be replaced have been modified since the query started. Should we go
back and update those operations?
I think people also expect those operations to have the semantics that they
currently do because that matches Hive. It would be strange for them to either
implement a stricter isolation level, or to prevent using a stricter isolation
level in merge operations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
