yyanyy commented on a change in pull request #1747:
URL: https://github.com/apache/iceberg/pull/1747#discussion_r521838314
##########
File path: api/src/test/java/org/apache/iceberg/transforms/TestResiduals.java
##########
@@ -214,6 +218,36 @@ public void testInTimestamp() {
Assert.assertEquals("Residual should be alwaysFalse", alwaysFalse(),
residual);
}
+ @Test
+ public void testInNaN() {
Review comment:
You mean testing `InNaN` case for other evaluators? Yeah I'll do that
##########
File path:
parquet/src/main/java/org/apache/iceberg/parquet/ParquetDictionaryRowGroupFilter.java
##########
@@ -148,6 +148,16 @@ public Boolean or(Boolean leftResult, Boolean rightResult)
{
return ROWS_MIGHT_MATCH;
}
+ @Override
+ public <T> Boolean isNaN(BoundReference<T> ref) {
+ return ROWS_MIGHT_MATCH;
Review comment:
Thanks! I'll see how it works
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
