rdblue commented on a change in pull request #1747:
URL: https://github.com/apache/iceberg/pull/1747#discussion_r521674115
##########
File path:
data/src/test/java/org/apache/iceberg/data/TestMetricsRowGroupFilter.java
##########
@@ -281,6 +295,37 @@ public void testNoNulls() {
Assert.assertTrue("Should read: struct type is not skipped", shouldRead);
}
+ @Test
+ public void testIsNaN() {
+ boolean shouldRead = shouldRead(isNaN("all_nans"));
+ Assert.assertTrue("Should read: not enough information", shouldRead);
Review comment:
I don't think the context is correct. All of the values are NaN.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
