yyanyy commented on a change in pull request #1747:
URL: https://github.com/apache/iceberg/pull/1747#discussion_r521837613
##########
File path:
api/src/main/java/org/apache/iceberg/expressions/ExpressionVisitors.java
##########
@@ -75,6 +75,14 @@ public R or(R leftResult, R rightResult) {
return null;
}
+ public <T> R isNaN(BoundReference<T> ref) {
+ return null;
+ }
+
+ public <T> R notNaN(BoundReference<T> ref) {
+ return null;
Review comment:
I initially made these methods abstract to ensure I implemented them in
all the child classes, but `UnsupportedOperationException` is definitely a
better idea!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
