bryanck commented on code in PR #15059:
URL: https://github.com/apache/iceberg/pull/15059#discussion_r2695653491
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/StreamingOffset.java:
##########
@@ -24,24 +24,31 @@
import java.io.InputStream;
import java.io.StringWriter;
import java.io.UncheckedIOException;
-import java.util.Locale;
+import java.util.Optional;
+import org.apache.iceberg.Snapshot;
+import org.apache.iceberg.SnapshotSummary;
import org.apache.iceberg.relocated.com.google.common.base.Objects;
import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
import org.apache.iceberg.util.JsonUtil;
+import org.apache.iceberg.util.PropertyUtil;
import org.apache.spark.sql.connector.read.streaming.Offset;
-class StreamingOffset extends Offset {
- static final StreamingOffset START_OFFSET = new StreamingOffset(-1L, -1,
false);
+public class StreamingOffset extends Offset {
Review Comment:
Does this need to be public?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
