bryanck commented on code in PR #15059:
URL: https://github.com/apache/iceberg/pull/15059#discussion_r2695735679
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/StreamingOffset.java:
##########
@@ -24,24 +24,31 @@
import java.io.InputStream;
import java.io.StringWriter;
import java.io.UncheckedIOException;
-import java.util.Locale;
+import java.util.Optional;
+import org.apache.iceberg.Snapshot;
+import org.apache.iceberg.SnapshotSummary;
import org.apache.iceberg.relocated.com.google.common.base.Objects;
import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
import org.apache.iceberg.util.JsonUtil;
+import org.apache.iceberg.util.PropertyUtil;
import org.apache.spark.sql.connector.read.streaming.Offset;
-class StreamingOffset extends Offset {
- static final StreamingOffset START_OFFSET = new StreamingOffset(-1L, -1,
false);
+public class StreamingOffset extends Offset {
+ static final StreamingOffset START_OFFSET = new StreamingOffset(-1L, -1,
false, -1L, -1L);
private static final int CURR_VERSION = 1;
private static final String VERSION = "version";
private static final String SNAPSHOT_ID = "snapshot_id";
private static final String POSITION = "position";
private static final String SCAN_ALL_FILES = "scan_all_files";
+ private static final String SNAPSHOT_TIMESTAMP_MS = "snapshot_timestamp_ms";
+ private static final String SNAPSHOT_TOTAL_ROWS = "snapshot_total_rows";
private final long snapshotId;
private final long position;
private final boolean scanAllFiles;
+ private final long snapshotTimestampMillis;
+ private final long snapshotTotalRows;
Review Comment:
I wasn't clear why these need to be added?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
