RjLi13 commented on code in PR #15059:
URL: https://github.com/apache/iceberg/pull/15059#discussion_r2696450588
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/StreamingOffset.java:
##########
@@ -51,14 +58,23 @@ class StreamingOffset extends Offset {
* @param position The position of last scanned file in snapshot.
* @param scanAllFiles whether to scan all files in a snapshot; for example,
to read all data when
* starting a stream.
+ * @param snapshotTimestampMillis The time the snapshot was created
+ * @param snapshotTotalRows Total rows in the snapshot
*/
- StreamingOffset(long snapshotId, long position, boolean scanAllFiles) {
+ public StreamingOffset(
Review Comment:
Good catch, I originally had it to match the public interface
SparkMicroBatchPlanner, only to realize all of them are implementation details.
Reverting and making the planners package private as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
