kevinjqliu commented on code in PR #2826:
URL: https://github.com/apache/iceberg-python/pull/2826#discussion_r2696421781
##########
pyiceberg/catalog/rest/__init__.py:
##########
@@ -382,10 +399,16 @@ def _split_identifier_for_path(
self, identifier: str | Identifier | TableIdentifier, kind:
IdentifierKind = IdentifierKind.TABLE
) -> Properties:
if isinstance(identifier, TableIdentifier):
- return {"namespace":
NAMESPACE_SEPARATOR.join(identifier.namespace.root), kind.value:
identifier.name}
+ return {
+ "namespace":
self._encode_namespace_path(tuple(identifier.namespace.root)),
+ kind.value: quote(identifier.name, safe=""),
Review Comment:
nit: should we make this a helper function? i can see a scenario where
someone will forget to use `quote`
##########
pyiceberg/catalog/rest/__init__.py:
##########
@@ -958,14 +982,7 @@ def update_namespace_properties(
@retry(**_RETRY_ARGS)
def namespace_exists(self, namespace: str | Identifier) -> bool:
namespace_tuple = self._check_valid_namespace_identifier(namespace)
- namespace = NAMESPACE_SEPARATOR.join(namespace_tuple)
- # fallback in order to work with older rest catalog implementations
- if Capability.V1_NAMESPACE_EXISTS not in self._supported_endpoints:
- try:
- self.load_namespace_properties(namespace_tuple)
- return True
- except NoSuchNamespaceError:
- return False
Review Comment:
is this intentional? i think we still need this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
